Skip to content

Feature/model centered#1151

Merged
Jammy2211 merged 56 commits intofeature/jax_wrapperfrom
feature/model_centered
Jun 24, 2025
Merged

Feature/model centered#1151
Jammy2211 merged 56 commits intofeature/jax_wrapperfrom
feature/model_centered

Conversation

@Jammy2211
Copy link
Copy Markdown
Collaborator

📌 Updated Prior Passing Behaviour

This PR changes the default behaviour for how priors are passed from one model fit to the next.

Previously, priors were automatically updated to be centered on the median of the posterior from a previous result — using truncated Gaussians whose parameters reflected that inferred solution. While useful when samplers were less robust, this approach could introduce subtle shifts in results depending on prior updates.

Now, by default, priors are passed using the original priors defined in the configuration, without modification based on the previous fit.

✅ Benefits:

  • Results are now fully reproducible and no longer depend on arbitrary prior updates between fits.
  • The behaviour is more transparent and consistent, especially for workflows involving chaining models or rerunning fits.

🔄 Legacy Behaviour Still Available:

The previous behaviour — centering priors around the last result — is still available via the model_centred API, which explicitly builds new priors based on the previous fit’s inferred values.

This change improves reproducibility while still allowing flexible workflows when prior adaptation is needed.

@Jammy2211 Jammy2211 requested a review from rhayes777 June 23, 2025 15:44
@Jammy2211 Jammy2211 changed the base branch from main to feature/jax_wrapper June 23, 2025 16:08
@Jammy2211 Jammy2211 merged commit 484e59d into feature/jax_wrapper Jun 24, 2025
0 of 4 checks passed
@Jammy2211 Jammy2211 deleted the feature/model_centered branch June 24, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants